Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StableDiffusion3PAGImg2Img Pipeline + Fix SD3 Unconditional PAG #9932

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

painebenjamin
Copy link
Contributor

What does this PR do?

This PR does two things:

  1. Adds StableDiffusion3PAGImg2ImgPipeline, tests and documentation.
  2. Fixes a bug with SD3 + PAG in general which caused unconditional PAG generation to fail (PAGJointAttentionProcessor2_0 was failing due to it receiving attention_mask as a keyword argument.)

Before submitting

Who can review?

Anyone who is interested, but particularly @yiyixuxu and @asomoza

Images

All are with SD3-Medium-Diffusers

Test output - PAG+CFG
test_pag_cfg

Test output - PAG only
test_pag_uncond

Docstring example output (PAG+CFG):
output

self._joint_attention_kwargs = joint_attention_kwargs
self._interrupt = False
self._pag_scale = pag_scale
self._pag_adaptive_scale = pag_adaptive_scale #
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self._pag_adaptive_scale = pag_adaptive_scale #
self._pag_adaptive_scale = pag_adaptive_scale

Copy link
Contributor

@jeongiin jeongiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I found this work interesting while reading it and noticed what seemed to be a typo, so I removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants