Skip to content

Dont set scale to zero as default when creating an Endpoint #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomaarsen
Copy link
Member

Hello!

Pull Request overview

  • Dont set scale to zero as default when creating an Endpoint

Details

As discussed internally, this PR sets the scale_to_zero_timeout to None by default. It's not entirely clear to me if the min_replica/max_replica is also intended to be set to None from the discussion though - we can make those changes still.

Also, when someone specifies the scale_to_zero_timeout, we can help them out by overriding the min_replica to 0, but we can also do nothing as users will get an error anyways that the minReplica should not be 1.

I've also added an example of how to create an endpoint that scales to zero, and I quickly tested that running that example with the new scale_to_zero_timeout & min_replica defaults indeed creates an endpoint that doesn't scale to zero.

cc @Wauplin @Vaibhavs10 @ErikKaum

  • Tom Aarsen

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants