Expand file lock scope to resolve concurrency issues during downloads #3063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humengyu2012
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request overview
Expand file lock scope to resolve concurrency issues during downloads
Details
We want to use a network file system as the cache directory (HF_HOME). After testing various network file systems(such as NFS), we observed strange errors when multiple requests concurrently download the same file.
We found that some symlink operations are protected by locks, while others are not, which can lead to conflicts.
In particular, on file systems that lack symlink support, symlink operations degrade into copy and mv commands, which further exacerbate these conflicts.
Therefore, I created this PR to expand the scope of the flock in order to resolve these conflicts.