Update "past_sequence_length + 1" shape dimension name to "past_sequence_length + sequence_length" #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gth" instead of "past_sequence_length + 1" since the output length depends on the input sequence_length which may not be 1, e.g. when filling the kv-cache
PatrikPerssonInceptron
changed the title
PatrikPerssonInceptron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a LLM to onnx with ``--task text-generation-with-past, the attention_mask and output kv-cache shapes contain a dimension set to "past_sequence_length + 1". This assumes that the input token sequence length is 1 which may not be the case when e.g. filling the kv-cache with the input prompt.
Fix
I updated the strings "past_sequence_length + 1" to "past_sequence_length + sequence_length" to reflect the case when the input sequence is longer than 1.
@fxmarty, @echarlaix, @JingyaHuang, @michaelbenayoun