Fix: Add Image.Image support to encode() overloads to resolve mypy error (#3462) #3485
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tomaarsen how to make sure i pass next time I make submission |
Contributor
Author
|
Hi @tomaarsen what can i do to move this PR further? |
Member
|
Hello @sahibpreetsingh12, Apologies for the delay. As I mentioned in #3462 (comment), I'm unsure whether I want to add this behaviour already. I think my preference is to include it in a large refactor that brings full multimodality support.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tomaarsen
In this PR I have tried #3462 by updating the
encode()method's type hints (including all relevant overload variants) to supportPIL.Image.Imageandlist[PIL.Image.Image].Summary of Changes:
ImagefromPILencode()overloads to includeImage.Imageandlist[Image.Image]encode()function signature accordinglyThis ensures that tools like
mypyno longer raise type errors when callingencode()with image inputs. As it is working correctly at inference time — the issue was limited to type checking.