Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wandb): pass fake dataset to avoid exception in trainer (see #34455) #34720

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CezaPasc
Copy link

What does this PR do?

This PR passes a fake evaluation dataset for the initialisation of the fake_trainer of WandB.
This is necessary, since the init of the Trainer checks if an eval_strategy is set and raises an error if the eval_dataset is missing.
This issue is documented in #34701.
The fix here is similar to the one in #34455.

Fixes # (issue)

  • Pass ["fake"] as eval_dataset during initialisation of fake_trainer for saving purposes of WandB.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants