Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modular] allow multiple modular files in the same model folder #36287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cyrilvallez
Copy link
Member

What does this PR do?

As per the title. It fixes the issue mentioned in #36261. There are 2 small issues:

  • we were relying on the folder name to get the model name -> of course this fails if several modular files are in the same folder, so we now parse the full filename instead
  • Small prefix issue, in case the two models (the new one, and the one imported) have a common name pattern (i.e. in this case, rt_detr_resnet and d_fine_resnet both end with resnet, the prefix matching would lead to inconsistencies

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants