Skip to content

[chat template] separate jinja logic from tokenizers #37602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Fixes #36713

@github-actions github-actions bot marked this pull request as draft April 18, 2025 08:36
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@zucchini-nlp zucchini-nlp marked this pull request as ready for review April 18, 2025 08:37
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp
Copy link
Member Author

@Rocketknight1 , kind ping

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this makes sense! A separate util is a lot cleaner than the Processor having to call the Tokenizer, especially if we want Processor templates to access processor-specific stuff in future.

@zucchini-nlp zucchini-nlp merged commit 8a9441d into huggingface:main May 7, 2025
20 checks passed
zucchini-nlp added a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return_assistant_tokens_mask argument is blocked in ProcessorMixin.apply_chat_template
3 participants