Skip to content

Support TP for save_pretrained() #38111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amd-xiaoyu12
Copy link
Contributor

What does this PR do?

When a model is quantized using TP, the save_pretrained() need to support TP when quantization is done and export to model to safetensor file.

The modification will combine the DTensor to full tensor in process which rank = 0 and export the result, for process with other rank number, the exporting task will be skipped.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's likely a problem that this changes the state of the model and makes it invalid after calling save_pretrained.

The in memory model should ideally be the same before and after calling save_pretrained.

@Rocketknight1
Copy link
Member

cc @ArthurZucker @Cyrilvallez

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! We have #37919 which should handle this as well! It is a bit more involved for some models, like LLama4, so let's focus on the other PR!
But thanks a lot for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants