Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unlimited sizes in HumioRepository #926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcjones-cybera
Copy link

Fixes #925

ingestSizeInGB and storageSizeInGB are currently defined with a minimum of 1. However the value of 0 is required to leave these as unlimited and to only use the timeInDays limits.

Changing this to 0 fixes this issue.

@mcjones-cybera mcjones-cybera requested a review from a team as a code owner February 26, 2025 22:37
@SaaldjorMike
Copy link
Member

Thank you for your contribution. Unfortunately, you cannot just update the yaml file. The YAML file is generated based on the source code, so you'd have to update the source code and generate the file again. That being said, you should be able to just leave out the retention settings and it should do the same.

@SaaldjorMike
Copy link
Member

Here's the golang code:
https://github.com/humio/humio-operator/blob/master/api/v1alpha1/humiorepository_types.go#L35-L47
after changing that you need to run "make manifests" and "make apidocs" to update the source & CRD docs.

…sizes

humio@40d73c9 set that ingestSizeInGB and storageSizeInGB with a minimum of 1. However the value of 0 is required to leave these as unlimited and to only use the timeInDays limits.

Changing this to 0 fixes this issue.
@mcjones-cybera
Copy link
Author

Thanks a ton for the clarification. I've updated the PR to reflect the correct file and the generated files after running the Make commands and am going to test again.

The docs are clear that omitting it is what we want and thanks to your comment I found the default that was explicitly setting it to 0 instead of leaving it omitted in our code.

I'm going to go ahead and test that omitting works as documented - in which case this change is not explicitly required - but I would suggest that because 0 is an allowed value the change is worth including.

@mcjones-cybera
Copy link
Author

I can confirm that the documentation is correct and fixing it so the values are omitted is working as expected.

As such - I'm good with this being closed and not merged, but because 0 is a valid value I don't want to close it unilaterally for someone who runs into the same issue we did.

@SaaldjorMike
Copy link
Member

I'll kick off a round of tests using your changes, and if they pass, I'll very likely merge this in short after.

Thank you again for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create HumioRepositories with unlimited size settings
2 participants