Skip to content

player.isInAir() #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

player.isInAir() #69

wants to merge 1 commit into from

Conversation

saori-eth
Copy link
Collaborator

lets me override jump / fall animation
not as granular as sharing jump / fall separately but felt like enough like enough

video:
https://github.com/user-attachments/assets/d6d77736-2adf-4690-b703-f7b6bcbe6d94

@ashconnell
Copy link
Contributor

The player variable in createPlayerProxy can be either PlayerLocal or PlayerRemote so if you tried calling this on the server or a remote player it would either crash the world or throw an error

@saori-eth
Copy link
Collaborator Author

@ashconnell I cant tell if you're suggesting to make it fail cleanly on the server or just don't add it at all.

is it okay to have local only player functions?

@ashconnell
Copy link
Contributor

I don't think there's an easy way to check this on a PlayerRemote so i'm not really sure what the best way forward is.

@saori-eth
Copy link
Collaborator Author

If this is the difference between having / not having custom animation sets i don't really understand why you can't just throw and error if trying to access the state on a remote player, the same way you can't access a vrm on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants