Skip to content

Moved the UI elements to their own inner div #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

cyberneticocult
Copy link

Moved the UI elements to their own inner div and left the disconnect overlay in coreui div.

Description

Added a second inner div for the coreui so the disconnect component in the original coreui div will remain visible when the inner div is hidden when the UI is toggled.

Fixes # 85

Type of change

  • [x ] Bug fix (non-breaking change which fixes a component issue)

How Has This Been Tested?

Please describe your tests:

  • [x ] World integration testing

Test Configuration:

  • Hyperfy Version: v0.10.0
  • Test world setup: local empty instance
  • Browser(s): brave
  • Node.js version: v22.11.0

Checklist:

  • [x ] My code follows Hyperfy's component architecture
  • [x ] I have performed a self-review
  • My changes maintain compatibility with existing worlds

@ashconnell
Copy link
Contributor

Oh this is a great solution to #85

Could you please point this PR to the dev branch so I can merge? :)

@cyberneticocult cyberneticocult changed the base branch from main to dev April 26, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants