Skip to content

fix: use saturating_add on received_movement_packets #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TestingPlant
Copy link
Collaborator

Without saturating_add, the server may panic if it receives too many movement packets within one tick.

Without saturating_add, the server may panic if it receives too many
movement packets within one tick.
@github-actions github-actions bot added the fix label May 3, 2025
Copy link

github-actions bot commented May 3, 2025

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  33.6 ns ...  33.5 ns ]      -0.30%
ray_intersection/aabb_size_1                       [  33.6 ns ...  33.5 ns ]      -0.33%
ray_intersection/aabb_size_10                      [  24.6 ns ...  24.6 ns ]      -0.09%
ray_intersection/ray_distance_1                    [  13.4 ns ...  13.4 ns ]      -0.14%
ray_intersection/ray_distance_5                    [  13.5 ns ...  13.6 ns ]      +0.04%
ray_intersection/ray_distance_20                   [  13.5 ns ...  13.5 ns ]      +0.02%
overlap/no_overlap                                 [  24.5 ns ...  24.4 ns ]      -0.10%
overlap/partial_overlap                            [  24.6 ns ...  24.6 ns ]      -0.02%
overlap/full_containment                           [  22.5 ns ...  22.5 ns ]      -0.09%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      +0.41%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      +0.15%
point_containment/boundary                         [   4.9 ns ...   4.9 ns ]      -0.43%

Comparing to e31bb7c

Copy link

codecov bot commented May 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.85%. Comparing base (e31bb7c) to head (12214ae).

Files with missing lines Patch % Lines
crates/hyperion/src/simulation/handlers.rs 0.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main     #894   +/-   ##
=======================================
  Coverage   20.85%   20.85%           
=======================================
  Files         161      161           
  Lines       16867    16867           
  Branches      468      468           
=======================================
  Hits         3518     3518           
  Misses      13285    13285           
  Partials       64       64           
Files with missing lines Coverage Δ
crates/hyperion/src/simulation/handlers.rs 4.20% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants