Skip to content

fix(ingress): don't fetch skins for players without uuids #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TestingPlant
Copy link
Collaborator

The server can skip fetching the skin in this case because the player does not have a skin.

The server can skip fetching the skin in this case because the player
does not have a skin.
@github-actions github-actions bot added the fix label May 3, 2025
Copy link

github-actions bot commented May 3, 2025

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  34.3 ns ...  34.2 ns ]      -0.30%
ray_intersection/aabb_size_1                       [  33.0 ns ...  33.0 ns ]      +0.09%
ray_intersection/aabb_size_10                      [  24.1 ns ...  24.1 ns ]      +0.00%
ray_intersection/ray_distance_1                    [  13.4 ns ...  13.5 ns ]      +0.26%
ray_intersection/ray_distance_5                    [  13.5 ns ...  14.0 ns ]      +3.48%
ray_intersection/ray_distance_20                   [  13.6 ns ...  14.0 ns ]      +3.16%
overlap/no_overlap                                 [  24.4 ns ...  24.6 ns ]      +0.64%
overlap/partial_overlap                            [  24.4 ns ...  25.0 ns ]      +2.10%
overlap/full_containment                           [  22.5 ns ...  22.5 ns ]      -0.17%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      -0.14%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      +0.04%
point_containment/boundary                         [   4.9 ns ...   4.9 ns ]      +0.07%

Comparing to e31bb7c

Copy link

codecov bot commented May 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 20.85%. Comparing base (e31bb7c) to head (8163028).

Files with missing lines Patch % Lines
crates/hyperion/src/ingress/mod.rs 0.00% 14 Missing ⚠️
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   20.85%   20.85%   -0.01%     
==========================================
  Files         161      161              
  Lines       16867    16870       +3     
  Branches      468      469       +1     
==========================================
  Hits         3518     3518              
- Misses      13285    13288       +3     
  Partials       64       64              
Files with missing lines Coverage Δ
crates/hyperion/src/ingress/mod.rs 22.17% <0.00%> (-0.16%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dyc3
dyc3 previously approved these changes May 3, 2025
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link

github-actions bot commented May 4, 2025

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  35.8 ns ...  35.8 ns ]      -0.07%
ray_intersection/aabb_size_1                       [  34.5 ns ...  34.6 ns ]      +0.38%
ray_intersection/aabb_size_10                      [  24.4 ns ...  24.3 ns ]      -0.44%
ray_intersection/ray_distance_1                    [  13.8 ns ...  13.8 ns ]      -0.40%
ray_intersection/ray_distance_5                    [  13.8 ns ...  13.8 ns ]      +0.01%
ray_intersection/ray_distance_20                   [  13.8 ns ...  13.8 ns ]      +0.23%
overlap/no_overlap                                 [  24.8 ns ...  24.8 ns ]      +0.10%
overlap/partial_overlap                            [  25.0 ns ...  25.1 ns ]      +0.10%
overlap/full_containment                           [  23.2 ns ...  23.3 ns ]      +0.16%
point_containment/inside                           [   5.1 ns ...   5.1 ns ]      -0.34%
point_containment/outside                          [   4.5 ns ...   4.5 ns ]      -0.03%
point_containment/boundary                         [   5.1 ns ...   5.2 ns ]      +0.58%

Comparing to e31bb7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants