-
-
Notifications
You must be signed in to change notification settings - Fork 29
fix(ingress): don't fetch skins for players without uuids #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TestingPlant
wants to merge
2
commits into
main
Choose a base branch
from
testingplant/offline-skins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server can skip fetching the skin in this case because the player does not have a skin.
Benchmark Results for general
Comparing to e31bb7c |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #895 +/- ##
==========================================
- Coverage 20.85% 20.85% -0.01%
==========================================
Files 161 161
Lines 16867 16870 +3
Branches 468 469 +1
==========================================
Hits 3518 3518
- Misses 13285 13288 +3
Partials 64 64
🚀 New features to boost your workflow:
|
dyc3
previously approved these changes
May 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Benchmark Results for general
Comparing to e31bb7c |
dyc3
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server can skip fetching the skin in this case because the player does not have a skin.