Skip to content

Feat: Disable stun for Symon mode #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Feat: Disable stun for Symon mode #1362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/looper/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ function addFailedRequestAssertions(assertions: ProbeAlert[]) {

export async function loopCheckSTUNServer(interval: number): Promise<unknown> {
// if stun is disabled, no need to create interval
if (interval === -1) return
if (interval === DISABLE_STUN) return

// if interval = 0 get ip once and exit. No need to setup interval.
if (interval === 0 || getContext().isTest) {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/public-ip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ let publicNetworkInfo: PublicNetwork | undefined
async function pokeStun(): Promise<string> {
// for testing, bypass ping/stun server... apparently ping cannot run in github actions
// reference: https://github.com/actions/virtual-environments/issues/1519
if (getContext().isTest) {
if (getContext().isTest || getContext().flags.stun === -1) {
return '192.168.1.1' // adding for specific asserts in other tests
}

Expand Down
Loading