-
Notifications
You must be signed in to change notification settings - Fork 308
fix(satp): add check in satp to verify smart contract ontology syntax #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a90c967 to
466a978
Compare
e28231a to
bba6481
Compare
LordKubaya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the validators to another file in the ontology-manager folder.
Also, change the ontologies to be in the type of the issue.
...n-satp-hermes/src/main/typescript/cross-chain-mechanisms/bridge/ontology/ontology-manager.ts
Outdated
Show resolved
Hide resolved
...n-satp-hermes/src/main/typescript/cross-chain-mechanisms/bridge/ontology/ontology-manager.ts
Outdated
Show resolved
Hide resolved
...n-satp-hermes/src/main/typescript/cross-chain-mechanisms/bridge/ontology/ontology-manager.ts
Outdated
Show resolved
Hide resolved
1c1d902 to
4bcb5e1
Compare
032734d to
3e23668
Compare
8a9a43d to
e84282e
Compare
b3bb285 to
a14f896
Compare
9bee4bd to
1ae6a34
Compare
6195ccd to
6ccee8f
Compare
2e43487 to
43a0744
Compare
43a0744 to
a0931cd
Compare
LordKubaya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a0931cd to
3b4c8b8
Compare
Head branch was pushed to by a user without write access
7527320 to
adff480
Compare
Signed-off-by: Tomás Silva <[email protected]>
adff480 to
efc0f7f
Compare
fix(satp): add check in satp to verify smart contract ontology syntax
Fixes the expected ontology format to match the format stated in the corresponding issue's description.
Completes the verifyOntology function that validates the existence and validity of all required ontology parameters.
Due to an issue, this new PR is a continuation from PR #3840.
Resolves #3746
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.