Skip to content

Conversation

@Tomas-Silva2187
Copy link
Contributor

@Tomas-Silva2187 Tomas-Silva2187 commented Apr 24, 2025

fix(satp): add check in satp to verify smart contract ontology syntax

Fixes the expected ontology format to match the format stated in the corresponding issue's description.
Completes the verifyOntology function that validates the existence and validity of all required ontology parameters.

Due to an issue, this new PR is a continuation from PR #3840.

Resolves #3746

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@Tomas-Silva2187 Tomas-Silva2187 changed the title Fix(satp): Add check in SATP gateway to verify smart contract's ontol… fix(satp): add check in satp to verify smart contract ontology Apr 24, 2025
@Tomas-Silva2187 Tomas-Silva2187 changed the title fix(satp): add check in satp to verify smart contract ontology fix(satp): add check in satp to verify smart contract ontology syntax Apr 24, 2025
@RafaelAPB RafaelAPB force-pushed the satp-dev branch 2 times, most recently from e28231a to bba6481 Compare May 2, 2025 15:07
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the validators to another file in the ontology-manager folder.

Also, change the ontologies to be in the type of the issue.

@RafaelAPB RafaelAPB force-pushed the satp-dev branch 3 times, most recently from 1c1d902 to 4bcb5e1 Compare May 23, 2025 13:52
@Tomas-Silva2187 Tomas-Silva2187 changed the base branch from satp-dev to satp-stg June 16, 2025 11:40
@Tomas-Silva2187 Tomas-Silva2187 force-pushed the testDev branch 2 times, most recently from 032734d to 3e23668 Compare June 18, 2025 13:17
@RafaelAPB RafaelAPB force-pushed the satp-stg branch 4 times, most recently from 8a9a43d to e84282e Compare June 23, 2025 14:18
@RafaelAPB RafaelAPB force-pushed the satp-stg branch 8 times, most recently from b3bb285 to a14f896 Compare September 29, 2025 04:43
@RafaelAPB RafaelAPB force-pushed the satp-stg branch 2 times, most recently from 9bee4bd to 1ae6a34 Compare October 1, 2025 13:03
@Tomas-Silva2187 Tomas-Silva2187 changed the base branch from satp-stg to main October 20, 2025 11:28
@RafaelAPB RafaelAPB added this to the SATP-Hermes v0.0.4-beta milestone Oct 20, 2025
@Tomas-Silva2187 Tomas-Silva2187 force-pushed the testDev branch 6 times, most recently from 2e43487 to 43a0744 Compare October 30, 2025 17:29
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelAPB RafaelAPB enabled auto-merge (rebase) November 6, 2025 16:54
auto-merge was automatically disabled November 6, 2025 17:02

Head branch was pushed to by a user without write access

@Tomas-Silva2187 Tomas-Silva2187 force-pushed the testDev branch 2 times, most recently from 7527320 to adff480 Compare November 7, 2025 16:39
@RafaelAPB RafaelAPB merged commit c34879c into hyperledger-cacti:main Nov 7, 2025
137 of 150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(satp): Add check in SATP gateway to verify smart contract's ontolology syntax

3 participants