fix(fabric-interop-cc): fix function name in comment

[findmyhappy]

Pull Request Requirements

• Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
• Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
• Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

• Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
• Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

fix function name in comment

[outSH]

Thanks! I've left a comment in code.

Also, please update the commit/PR message to fix(fabric-interop-cc): fix function name in comment - we use parentheses to specify component that is being changed, and it's more of a fix than a chore work.

And, if possible, try to include short description of the changes in the commit message.

[findmyhappy]

Please review again.

[outSH]

LGTM, thanks!

[findmyhappy]

LGTM, thanks!

My pleasure.

[sandeepnRES]

Hi @findmyhappy , thanks for the PR, but one question, Is there a need for these changes? I don't see how existing comment is a problem.

[findmyhappy]

Hi @findmyhappy , thanks for the PR, but one question, Is there a need for these changes? I don't see how existing comment is a problem.

Thank you for your response. I noticed that the first word in the comments of the two methods was inconsistent with the method names, which led me to make modifications. The other maintainer also gave me additional suggestions.

You are more familiar with this, and I am willing to listen to and respect your advice.

Thanks again.

[sandeepnRES]

Hi @findmyhappy , thanks for the PR, but one question, Is there a need for these changes? I don't see how existing comment is a problem.

Thank you for your response. I noticed that the first word in the comments of the two methods was inconsistent with the method names, which led me to make modifications. The other maintainer also gave me additional suggestions.

You are more familiar with this, and I am willing to listen to and respect your advice.

Thanks again.

Yeah you are right function name is inconsistent. Can you add correct the function name in the comment description, just to be consistent with comments at other places.
Thank you.

[RafaelAPB]

@outSH @sandeepnRES are we good to merge this?

[outSH]

@RafaelAPB Fine by me, but approval from Sandeep is more important here :)

[sandeepnRES]

Hi @findmyhappy , thanks for the PR, but one question, Is there a need for these changes? I don't see how existing comment is a problem.

Thank you for your response. I noticed that the first word in the comments of the two methods was inconsistent with the method names, which led me to make modifications. The other maintainer also gave me additional suggestions.
You are more familiar with this, and I am willing to listen to and respect your advice.
Thanks again.

Yeah you are right function name is inconsistent. Can you add correct the function name in the comment description, just to be consistent with comments at other places. Thank you.

I wanted this to be addressed before merging.
Also I see that there is a merge commit created into this. Can you please remove it and merge with rebase only to have linear history?
@findmyhappy @RafaelAPB Thanks.

[sandeepnRES]

@findmyhappy Closing this PR, as it has merge commit and thus can not be merged, and it seems you are busy. So please create a fresh PR (when you are back) where there is only one commit and please address my comment above.

[findmyhappy]

@findmyhappy Closing this PR, as it has merge commit and thus can not be merged, and it seems you are busy. So please create a fresh PR (when you are back) where there is only one commit and please address my comment above.

@sandeepnRES Sorry for coming late to handle this. I have been busy with school evaluations for the past two months.😂

Please review again. #4052