Skip to content

Conversation

@pandaio22
Copy link
Contributor

@pandaio22 pandaio22 commented Sep 22, 2025

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@RafaelAPB
Copy link
Contributor

Blocked by failing pipeline

@RafaelAPB RafaelAPB force-pushed the satp-stg branch 17 times, most recently from b3bb285 to a14f896 Compare September 29, 2025 04:43
@RafaelAPB RafaelAPB force-pushed the satp-stg branch 2 times, most recently from 9bee4bd to 1ae6a34 Compare October 1, 2025 13:03
@pandaio22 pandaio22 changed the base branch from satp-stg to main October 13, 2025 11:00
@pandaio22 pandaio22 force-pushed the satp-stg-cbdc-ci branch 2 times, most recently from 6538227 to 79b60a0 Compare October 15, 2025 20:41
@pandaio22 pandaio22 marked this pull request as ready for review October 19, 2025 10:36
Copy link
Contributor

@AndreAugusto11 AndreAugusto11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But please, check the failing CI actions. run-satp-tests-recovery (I think they should be disabled) and run-satp-tests-integration-docker. These are not failing because of the report, but the tests are actually failing.

@RafaelAPB RafaelAPB added this to the SATP-Hermes v0.0.4-beta milestone Oct 20, 2025
@RafaelAPB RafaelAPB added the IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. label Oct 20, 2025
@RafaelAPB
Copy link
Contributor

@pandaio22 please rebase so we can merge. @AndreAugusto11 can you please provide your review?

Signed-off-by: Rodolfo Carapau <[email protected]>

ci(satp-hermes): changed runner

Signed-off-by: Rodolfo Carapau <[email protected]>
CACTI_CUSTOM_CHECKS_REQUIRED_OPENAPI_SPEC_VERSION: 3.0.3
needs: build-dev
runs-on: ubuntu-22.04
runs-on: ubuntu-latest-16-cores
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary anymore; could you change it back to the smaller runner?

Comment on lines +35 to +41
# Download build artifacts using reusable action
#- name: Download SATP build artifacts
# uses: ./.github/actions/satp-download-build-artifacts

# Download generated artifacts
#- name: Download generated artifacts
# uses: ./.github/actions/satp-download-generated-artifacts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is repeated twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants