-
Couldn't load subscription status.
- Fork 309
feat(satp-hermes): added cbdc ci #3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e2d943b to
f3f1722
Compare
|
Blocked by failing pipeline |
b3bb285 to
a14f896
Compare
9bee4bd to
1ae6a34
Compare
6538227 to
79b60a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But please, check the failing CI actions. run-satp-tests-recovery (I think they should be disabled) and run-satp-tests-integration-docker. These are not failing because of the report, but the tests are actually failing.
fbe6b3e to
4ee2a08
Compare
|
@pandaio22 please rebase so we can merge. @AndreAugusto11 can you please provide your review? |
Signed-off-by: Rodolfo Carapau <[email protected]> ci(satp-hermes): changed runner Signed-off-by: Rodolfo Carapau <[email protected]>
0b1b57b to
3a4fa1d
Compare
| CACTI_CUSTOM_CHECKS_REQUIRED_OPENAPI_SPEC_VERSION: 3.0.3 | ||
| needs: build-dev | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ubuntu-latest-16-cores |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary anymore; could you change it back to the smaller runner?
| # Download build artifacts using reusable action | ||
| #- name: Download SATP build artifacts | ||
| # uses: ./.github/actions/satp-download-build-artifacts | ||
|
|
||
| # Download generated artifacts | ||
| #- name: Download generated artifacts | ||
| # uses: ./.github/actions/satp-download-generated-artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is repeated twice
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.