Skip to content

Conversation

@RafaelAPB
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@RafaelAPB RafaelAPB force-pushed the satp-main-document-satp-typedoc branch 2 times, most recently from a36cc47 to 5746d08 Compare October 6, 2025 15:48
@RafaelAPB RafaelAPB force-pushed the satp-main-document-satp-typedoc branch from 5746d08 to d9ea7c3 Compare October 8, 2025 06:37
@RafaelAPB RafaelAPB force-pushed the satp-main-document-satp-typedoc branch from d9ea7c3 to 4bcd6f3 Compare October 18, 2025 16:17
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are changes in the package.json of the satp-hermes package. Are those right?

@RafaelAPB
Copy link
Contributor Author

There are changes in the package.json of the satp-hermes package. Are those right?

It was a test and I will revert it.

@RafaelAPB RafaelAPB force-pushed the satp-main-document-satp-typedoc branch from 4bcd6f3 to 88ba154 Compare October 20, 2025 21:34
@RafaelAPB
Copy link
Contributor Author

Related to #4021

@RafaelAPB RafaelAPB added this to the SATP-Hermes v0.0.4-beta milestone Oct 20, 2025
@RafaelAPB RafaelAPB added the IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. label Oct 20, 2025
@RafaelAPB RafaelAPB removed this from SATP-Hermes Oct 20, 2025
@RafaelAPB RafaelAPB force-pushed the satp-main-document-satp-typedoc branch 2 times, most recently from 3853378 to 3631bf0 Compare October 29, 2025 06:53
RafaelAPB and others added 3 commits October 30, 2025 19:09
@RafaelAPB RafaelAPB force-pushed the satp-main-document-satp-typedoc branch from 3631bf0 to 9793ac5 Compare October 30, 2025 17:09
@RafaelAPB RafaelAPB enabled auto-merge (rebase) October 30, 2025 17:10
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants