-
Notifications
You must be signed in to change notification settings - Fork 308
feat(weaver): weaver fabric driver connector implementation #4020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(weaver): weaver fabric driver connector implementation #4020
Conversation
6318f35 to
df31db1
Compare
df31db1 to
b18a4e6
Compare
|
@LordKubaya We should rename the package Is this just a matter of renaming the folder or will there be several (disruptive) changes required within? If it's the latter, we can do the renaming in a subsequent PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer these files not be checked in here (i.e., as part of the Fabric ledger connector package). These protobuf structures were created in Weaver to be commonly used across interoperation pipeline modules and apps, and aren't specific to the Fabric driver.
Ideally, we'd like to expose them through a separate (and dedicated) package, which is what we did in Weaver.
Normally, whenever any of these structures change, a build-and-publish is triggered via GitHub Action for target languages (Go, JS, Java/Kotlin, Rust, Solidity). The respective modules depending on them simply add library dependencies (e.g., in a package.json for a JS/TS code package).
Let's discuss how to avoid having this folder within this package.
b18a4e6 to
22299ef
Compare
Signed-off-by: Carlos Amaro <[email protected]>
b995b05 to
5982d2b
Compare
In my opinion, this should be done after this PR. |
e8737e4 to
a392394
Compare
Signed-off-by: Carlos Amaro <[email protected]>
a392394 to
e23910e
Compare
feat(weaver): weaver fabric driver connector implementation