Skip to content

Conversation

@pandaio22
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@pandaio22 pandaio22 requested a review from LordKubaya as a code owner October 26, 2025 14:53
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreAugusto11 AndreAugusto11 enabled auto-merge (rebase) October 26, 2025 17:41
@AndreAugusto11 AndreAugusto11 enabled auto-merge (rebase) October 26, 2025 17:41
@LordKubaya
Copy link
Contributor

This is a chore, not a fix. If you use these names, they will appear in the realise notes. We don't want CI information in the release notes.

@LordKubaya LordKubaya disabled auto-merge October 27, 2025 09:59
@pandaio22 pandaio22 force-pushed the satp-skip-recovery-test-fix branch from 8fdd55e to 029881d Compare October 28, 2025 19:14
@pandaio22 pandaio22 force-pushed the satp-skip-recovery-test-fix branch from 029881d to 3ac66f7 Compare October 28, 2025 19:21
@pandaio22 pandaio22 changed the title fix(satp-hermes): skip stage 1 recovery test chore(satp-hermes): skip stage 1 recovery test Oct 28, 2025
@RafaelAPB RafaelAPB merged commit aa0e6a2 into hyperledger-cacti:main Oct 29, 2025
142 of 157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants