(chore): Fix basic check failures #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Kumar Singh <[email protected]>
sadityakumar9211
force-pushed
the
fix-basic-check-failures
branch
from
c620792 to
d6f6b5e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes basic check failures by regenerating protobuf artifacts and updating vendor Go dependencies. The changes are mostly mechanical updates in generated mock files (replacing redundant empty struct definitions), a minor grouping of variable declarations in blockwriter.go, and an import ordering adjustment in storage.pb.go.
Reviewed Changes
Copilot reviewed 115 out of 116 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| orderer/common/multichannel/mocks/*.go | Updated empty struct declarations in various methods for brevity and consistency. |
| orderer/common/multichannel/blockwriter.go | Changed individual variable declarations into a grouped var block. |
| common/ledger/blkstorage/storage.pb.go | Adjusted import ordering formatting. |
| Other mocks files | Similar mechanical updates to empty struct declarations in method call tracking. |
Files not reviewed (1)
- go.mod: Language not supported
Signed-off-by: Aditya Kumar Singh <[email protected]>
Signed-off-by: Aditya Kumar Singh <[email protected]>
Signed-off-by: Aditya Kumar Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fix basic check failures by regenerating protobuf artifacts and vendor go dependencies.
Additional details
Steps for this fix:
make protosgo mod tidygo mod vendor./scripts/golinter.shRelated issues
n/a