Skip to content

Redeem: validate that TransferAction for Redeem has an issuer #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

aaadir
Copy link
Contributor

@aaadir aaadir commented Apr 27, 2025

Implementing Issue #1065
Update the Validate function of the actions to ensure the Issuer identity is there for Redeem TransferActions.

@aaadir aaadir added the enhancement New feature or request label Apr 27, 2025
@aaadir aaadir requested a review from adecaro April 27, 2025 12:42
@aaadir aaadir self-assigned this Apr 27, 2025
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, extend the unit tests. Thanks.

@aaadir
Copy link
Contributor Author

aaadir commented Apr 29, 2025

Added a unit test to action_test.go:TestAction_Validate and pushed.
done.

@adecaro adecaro self-requested a review May 13, 2025 04:59
@adecaro adecaro added this to the Q2 milestone May 13, 2025
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adecaro adecaro merged commit 18aba24 into main May 13, 2025
55 checks passed
@adecaro adecaro deleted the 1065_redeem_validate_TransferAction branch May 13, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate function for a TransferAction should ensure the Issuer identity is there
2 participants