Redeem: match TransferMetadata issuer #1067
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaadir , thanks for the PR. Please, introduce a unit-test to verify that the check is performed. Thanks. |
adecaro
requested changes
Apr 28, 2025
Signed-off-by: Allon Adir <[email protected]>
aaadir
force-pushed
the
1064_match_TransferMetadata_issuer
branch
from
049792c to
c3a3292
Compare
Signed-off-by: Allon Adir <[email protected]>
aaadir
force-pushed
the
1064_match_TransferMetadata_issuer
branch
from
85ac243 to
a673253
Compare
|
token/metadata_test.go:TestMetadata_TestMatchTransferAction now includes a new unit test for the match function, which now includes just a test that the new check for the issuer passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue #1064:
Extend the Match function of the token.TransferMetadata to make sure metadata and action match.