RequestApprovalResponderView misses empty rwset checks #1230 #1265
+8,091
−415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
force-pushed
the
1230-requestapprovalresponderview-misses-empty-rwset-checks
branch
2 times, most recently
from
464438b to
f5a156e
Compare
adecaro
force-pushed
the
1230-requestapprovalresponderview-misses-empty-rwset-checks
branch
2 times, most recently
from
e461611 to
a5c32bd
Compare
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]> # Conflicts: # go.mod # go.sum # token/services/identity/storage/kvs/hashicorp/go.mod # token/services/identity/storage/kvs/hashicorp/go.sum # Conflicts: # go.mod # go.sum # token/services/identity/storage/kvs/hashicorp/go.mod # token/services/identity/storage/kvs/hashicorp/go.sum
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
adecaro
force-pushed
the
1230-requestapprovalresponderview-misses-empty-rwset-checks
branch
from
a5c32bd to
a5f5114
Compare
Signed-off-by: Angelo De Caro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the additional checks and unit-tests.
The remaining TODO will be addressed in another PR.
This PR depends on hyperledger-labs/fabric-smart-client#1078.