Skip to content

cluster, helm: Add new Helm-chart "splice-info" #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

giner
Copy link
Contributor

@giner giner commented Apr 16, 2025

This helm charts runs a simple web-server to provide static deployment and dynamic runtime information as JSON files.

  • Static deployment configuration is published as JSON under /
  • Runtime part supports fetching DSO information from Scan and publishes it under /runtime/dso.json

@giner giner force-pushed the stas/cluster_helm_add_info branch 4 times, most recently from 672b440 to 1d1cf68 Compare April 16, 2025 11:12
@isegall-da
Copy link
Contributor

Thanks @giner . I haven't yet looked at it closely, but my main concern is that there's no tests for it.
Unfortunately that's still a bit hard to do in Splice directly, as there's no CI here (coming soon...), so I see two options: either we park this for a while, until we have enough testing infra in Splice for you to add tests, or we have someone from DA add tests in the internal repo. WDYT?

At a high level, we need to: deploy this in Pulumi (the Pulumi code is not yet in Splice though 😢 coming soon...), and add some logic to one of the preflight tests in apps\app

@giner
Copy link
Contributor Author

giner commented Apr 16, 2025

Whatever gets it merged (or rejected, also works for me :)) faster. If DA folks could add tests let's do that.

@isegall-da
Copy link
Contributor

Definitely aiming at merge, not reject. Let me see if someone can carve out a bit of time for this then.

This helm charts runs a simple web-server to provide static deployment
and dynamic runtime information as JSON files.

- Static deployment configuration is published as JSON under /
- Runtime part supports fetching DSO information from Scan and publishes
  it under /runtime/dso.json

Signed-off-by: Stanislav German-Evtushenko <[email protected]>
@giner giner force-pushed the stas/cluster_helm_add_info branch from 1d1cf68 to f90ad05 Compare April 16, 2025 14:12
sleep "$((period - (end_time - start_time)))";

if [ "$exit_code" -ne 0 ]; then
exit $exit_code;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exit makes the updater container restart if update fails (which makes the problem easily visible) while the main container keep serving the latest successfully fetched data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants