Skip to content

fix(sema): reject target gated builtin methods on wrong target #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aryanbaranwal001 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(sema): reject target gated builtin methods on wrong target #1890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eabbe20
fix(sema): reject target gated builtin methods on wrong target
aryanbaranwal001 Apr 25, 2026
bd5d4e4
Merge branch 'main' into fix/builtin-method-target-check
salaheldinsoliman May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/sema/builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,11 @@ pub(super) fn resolve_method_call(
let deref_ty = expr_ty.deref_memory();
let funcs: Vec<_> = BUILTIN_METHODS
.iter()
.filter(|func| func.name == id.name && func.method.contains(deref_ty))
.filter(|func| {
func.name == id.name
&& func.method.contains(deref_ty)
&& (func.target.is_empty() || func.target.contains(&ns.target))
})
.collect();

// try to resolve the arguments, give up if there are any errors
Expand Down Expand Up @@ -1523,6 +1527,19 @@ pub(super) fn resolve_method_call(
}

if funcs.is_empty() {
if BUILTIN_METHODS
.iter()
.any(|func| func.name == id.name && func.method.contains(deref_ty))
{
diagnostics.push(Diagnostic::error(
id.loc,
format!(
"method '{}' is not available on target {}",
id.name, ns.target
),
));
return Err(());
}
Ok(None)
} else {
diagnostics.extend(call_diagnostics);
Expand Down
Loading