fix(soroban): handle DynamicBytes in ABI spec, codec, and LLVM type system#1904
Open
aryanbaranwal001 wants to merge 2 commits into
Open
Conversation
… and codec Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Any solidity contract on soroban using
bytesas a function parameter or return type would panic at compile time. This was caused by three independent gaps in theDynamicBytesemit path.The following contract now compiles to a valid WASM binary:
Key Changes
codegen/encoding/soroban_encoding.rs: addedDynamicBytesarm tosoroban_decode_argandsoroban_encode_arg, same asStringandAddress.emit/soroban/mod.rs: addedDynamicBytesarm toemit_function_spec_entryfor both inputs and outputs.emit/binary.rs: extended the Soroban guard invar_ty_uses_pointer_storage()to coverDynamicBytes, on sorobanbytesisi64handle, not a ptr, so its LLVM alloca must bei64notptrTests
soroban_testcases/dynamic_bytes.rs: coveringset_datacall with empty bytes then withb"hello", reads back via the auto generateddata()getter, and asserts equality. Verifying all three fixed gaps.