Skip to content

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Nov 12, 2025

PR description

fields() is deprecated. properties() is almost the same but you don't get an iterator. propertyStream() gives you a stream so it made sense to use that instead

Fixed Issue(s)

Fixes some CodeQL deprecation warnings inc 1880

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Signed-off-by: Sally MacFarlane <[email protected]>
Copilot AI review requested due to automatic review settings November 12, 2025 01:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@macfarla macfarla marked this pull request as draft November 18, 2025 01:19
@macfarla
Copy link
Contributor Author

just double-checked, this is NOT covered by #8961 🙂

@macfarla macfarla marked this pull request as ready for review November 18, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants