feat: implement diff mode tracer #9442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
10 tasks
jframe
reviewed
Nov 21, 2025
...hyperledger/besu/ethereum/api/jsonrpc/internal/results/tracing/diff/StateTraceGenerator.java
Show resolved
Hide resolved
| * <li>A pre-state trace (complete state snapshot of relevant accounts) | ||
| * </ul> | ||
| */ | ||
| public class StateTraceGenerator { |
Contributor
There was a problem hiding this comment.
Although it's tested indirectly with the integration tests would still be good to get some unit tests around this
| // Case 2: Account existed pre-transaction | ||
| final String originalValueHex = rootAccount.getStorageValue(key).toHexString(); | ||
| // Record differences, or everything if pre-state mode is enabled | ||
| if (!originalValueHex.equals(newValueHex) || isPreState) { |
Contributor
There was a problem hiding this comment.
nit: Think it would be slightly better to do the comparison on the uint256 instead of comparing the hex string
| * Writes the "post" state for an account (diff mode). Includes only changed and non-zero | ||
| * fields. | ||
| */ | ||
| private void writePostNode( |
Contributor
There was a problem hiding this comment.
Looks like there is a bit of duplication with writeNode.
| try { | ||
| gen.writeStringField("balance", b); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
Contributor
There was a problem hiding this comment.
It probably makes sense to fail early if any exception occurs, but the same isn't being done for fields in writePostNode, should it be?
Signed-off-by: Gabriel-Trintinalia <[email protected]>
jframe
approved these changes
Nov 24, 2025
pinges
pushed a commit
to pinges/besu
that referenced
this pull request
Dec 15, 2025
* Implement pre state diff mode tracer Signed-off-by: Gabriel-Trintinalia <[email protected]> * add tests Signed-off-by: Gabriel-Trintinalia <[email protected]> * add tests Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove unused methods Signed-off-by: Gabriel-Trintinalia <[email protected]> * Accept PR suggestions Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests