[config] Add Orderer endpoint #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liran-funaro
force-pushed
the
orderer-endpoint
branch
2 times, most recently
from
5dba24c to
e03c91f
Compare
Contributor
|
LGTM. |
liran-funaro
force-pushed
the
orderer-endpoint
branch
from
e03c91f to
50e07de
Compare
liran-funaro
force-pushed
the
orderer-endpoint
branch
from
50e07de to
30d6b68
Compare
liran-funaro
force-pushed
the
orderer-endpoint
branch
4 times, most recently
from
91c102c to
455540a
Compare
Signed-off-by: Liran Funaro <[email protected]>
liran-funaro
force-pushed
the
orderer-endpoint
branch
from
455540a to
f1539ae
Compare
cendhu
approved these changes
Nov 12, 2025
Contributor
cendhu
left a comment
cendhu
left a comment
There was a problem hiding this comment.
LGTM. I have a suggestion but I am merging this PR.
Comment on lines
+92
to
+94
| // Schema 1: YAML. | ||
| // Schema 2: JSON. | ||
| // Schema 3: [id=ID,][msp-id=MspID,][broadcast,][deliver,][host=Host,][port=Port,][Host:Port]. |
Contributor
There was a problem hiding this comment.
I am not sure about supporting multiple schema formats, as too many choices are not always good. It would be better to support only the YAML schema within the YAML config file. Further, it would reduce the number of lines of code that we need to manage.
Contributor
Author
There was a problem hiding this comment.
We need to support at least two schemas. Scehma 1 (YAML, to the request of @pasquale95), and schema 3 to support regular endpoint for legacy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
yaml.v3