fix: resolve high CPU busy-loop in event loop - #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves a high CPU busy-loop condition in
hyprsunset's Wayland event loop.Cause
When
wl_display_prepare_read()fails (returns -1, e.g. due to pending events in the queue),preparedToReadis set tofalse. In this case,pollThreadskips callingpoll()but still triggers a wakeup to the event loop thread (shouldProcess = true).However, the event loop thread only calls
wl_display_dispatch_pending()ifpollfds[0].revents & POLLINis set. Sincepoll()was skipped,pollfds[0].reventsis not updated and does not have thePOLLINflag set. As a result, the pending events are never dispatched,wl_display_prepare_read()continues to fail, and the program enters an infinite tight loop consuming 100% CPU.Fix
Introduce a synchronized boolean
wlEventsPendingwhich is set totruewheneverwl_display_prepare_read()fails (meaning events are ready to be dispatched) orpollfds[0].revents & POLLINis set. The main loop checks this flag to determine when to callwl_display_dispatch_pending()andwl_display_flush().