feat: add "Hide window title bar" option independent of window title content - #135
Open
nbali wants to merge 3 commits into
Open
feat: add "Hide window title bar" option independent of window title content#135nbali wants to merge 3 commits into
nbali wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature that allows users to hide the timer window title bar via both the command line and the context menu. It introduces a
HideWindowTitleBaroption throughout the codebase, updates the UI and serialization logic to support this setting, and documents the new option in the usage and help files.New Feature: Hide Window Title Bar
HideWindowTitleBaroption toTimerOptions,CommandLineArguments, andTimerOptionsInfo, including support for serialization, deserialization, and property change notifications. [1] [2] [3] [4] [5] [6] [7]--hide-window-title-baroption, with support for aliases and default values. [1] [2] [3] [4]IsWindowTitleBarHiddenproperty, ensuring the title bar is hidden when either the old or new option is set. [1] [2] [3] [4]README.mdand updatedUsage.txtto reflect the new command-line flag and its description. [1] [2] [3]Setting "Window title" to "None" was the only way to hide the timer window's title bar, but that also removed the title from the taskbar. There was no way to show a meaningful title in the taskbar while hiding the title bar on the window itself.
Option plumbing
HideWindowTitleBarbool toTimerOptions, wired into construction, copy/clone, andTimerOptionsInfoserialization.Window behavior
IsWindowTitleBarHiddenonTimerWindow(WindowTitleMode == None || HideWindowTitleBar), notified whenever either source option changes.TimerWindow.xamlnow drives the title bar visibility from this single property instead of duplicating theWindowStyle/WindowChromesetters per condition.UI / CLI
--hide-window-title-barcommand-line switch (aliases-hb,/hb), documented inUsage.txtandREADME.md.Now a "Timer title" (or any other) window title mode can be combined with "Hide window title bar" to show a meaningful title in the taskbar without the title bar cluttering the window itself.