Bump the minimum version of CMake to 3.5, to be able to compile with CMake 4.0 #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
the
DLCCD_DB_INIT_DEFAULTdefinition accordinglyENDRELEASENOTES
See https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features
Here I'm not sure what's best. I added the following:
after
DLCCD_DB_INIT_DEFAULTis set and I get an empty string in the current version, while with this PR it will becomeI see this is only used in https://github.com/iLCSoft/LCCD/blob/master/source/src/lccd.cc#L44. One possibility would be to remove the definition and just return an empty string, which is the current behaviour.