Merge remaining Muon Collider changes from fork#202
Merged
tmadlener merged 39 commits intoiLCSoft:masterfrom Feb 10, 2025
Merged
Merge remaining Muon Collider changes from fork#202tmadlener merged 39 commits intoiLCSoft:masterfrom
tmadlener merged 39 commits intoiLCSoft:masterfrom
Conversation
Changed the __iter__ method to follow the Python 3 convention
Python3 compatibility of Reader class
Merge with Ilcsoft version v02-19-01
adding number of holes to track class
Replaced anajob utility with a Python version
Changed the __iter__ method to follow the Python 3 convention
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Release 02 09 for MC
tmadlener
approved these changes
Feb 10, 2025
Contributor
tmadlener
left a comment
tmadlener
left a comment
There was a problem hiding this comment.
Merging this as soon as the CI passes
tmadlener
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
anajob.pyexample python3 compatible (and remove python2 support) and install it asanajob.pyexecutable ifBUILD_ROOTDICTis enabled.ENDRELEASENOTES
This PR includes all remaining differences implemented in the MuonColliderSoft fork of LCIO.
The idea would be to merge these upstream and discontinue/archive the fork.