Conversation
tmadlener
reviewed
Mar 2, 2026
Contributor
tmadlener
left a comment
tmadlener
left a comment
There was a problem hiding this comment.
Can we make these unique_ptr? So that on event change we can simply reset and the rest is properly taken care of? Or is that too intrusive?
Contributor
Author
|
Done, I think this is equivalent to before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
_currentEventand_currentRunbestd::unique_ptrso that they are deleted in the destructor ofSIOReadersince currently the previous ones are deleted when reading the next event or run header, which doesn't happen for the last event or run header.default. Delete the move constructor and the move assignment operator. This is already the case, it's not explicitly written.ENDRELEASENOTES