-
Notifications
You must be signed in to change notification settings - Fork 370
Update Dependencies and switch entirely to yarn #2394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There's no need for npm and yarn to be used, in fact they cause weird issues when used together.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
|
Thanks for working on this! @Scavanger recently did fairly extensive work on Configurator, so they may have some useful comments or suggestions. |
|
Unfortunately, there is some overlap with #2285 Let's merge it first, then see what happens. |
|
The description gives good reasons why this needs to be done. I see it is still a work in progress. |
|
I would like to, but I wouldn't count on my ADHD ass to get to it any time soon :P |
User description
So. This is a much needed chore.
Firstly, using npm and yarn in the same project causes weird issues, like I couldn't install new dependencies for the web port.
Second, I'll go through all packages, but at least the following need updating:
[email protected]was depricated 7 years ago. The current version is[email protected]temphasn't been updated in 5 years, and depends on[email protected]which is 7 years old, and versions prior to v4 are no longer supported[email protected], 7 years old, replaced by[email protected]additionally
electron-forgeis on the latest version, but depends onsudo-promptwhick is dead, and[email protected]but versions prior to v9 are no longer supported@electron/packagerwhich also depends on[email protected]I'm certain that other packages are way out of date too
Full warnings
PR Type
Enhancement
Description
Upgrade OpenLayers from deprecated v4.6.5 to modern v10.6.1
Switch from CommonJS require to ES6 import syntax
Standardize package management to use yarn exclusively
Update code formatting and fix syntax inconsistencies
Changes diagram
Changes walkthrough 📝
gps.js
Modernize OpenLayers imports and formattingtabs/gps.js
require('openlayers')withimport * as ol from 'ol'waypointCollection.js
Update OpenLayers import syntaxjs/waypointCollection.js
require('openlayers')toimport * as ol from 'ol'groundstation.js
Modernize OpenLayers integrationjs/groundstation.js
require('openlayers')withimport * as ol from 'ol'styles.css
Disable deprecated OpenLayers CSSsrc/css/styles.css
package.json
Update OpenLayers dependencypackage.json
[email protected]with[email protected]