Skip to content

Conversation

@MrD-RC
Copy link
Member

@MrD-RC MrD-RC commented Nov 19, 2025

User description

For use with iNavFlight/inav#11122


PR Type

Enhancement


Description

  • Rename controlrate_profile to use_control_profile in FC configuration

  • Update mixer profile linking references from PID to control profile

  • Synchronize locale translations across multiple languages (English, Japanese, Ukrainian, Chinese)


Diagram Walkthrough

flowchart LR
  A["Old References<br/>controlrate_profile<br/>mixer_pid_profile_linking"] -- "Rename to" --> B["New References<br/>use_control_profile<br/>mixer_control_profile_linking"]
  B -- "Update" --> C["Configuration Files<br/>HTML UI<br/>Locale Strings"]
Loading

File Walkthrough

Relevant files
Enhancement
fc.js
Rename controlrate_profile to use_control_profile               

js/fc.js

  • Renamed controlrate_profile setting to use_control_profile in the FC
    configuration array
+1/-1     
mixer.html
Update mixer profile linking UI element names                       

tabs/mixer.html

  • Updated HTML element IDs from mixer_pid_profile_linking to
    mixer_control_profile_linking
  • Updated data-setting attribute to reference new control profile naming
  • Updated i18n references to match new locale keys
+3/-3     
Documentation
messages.json
Update English locale for control profile linking               

locale/en/messages.json

  • Renamed locale key mixer_pid_profile_linking to
    mixer_control_profile_linking
  • Renamed locale key mixer_pid_profile_linking_hint to
    mixer_control_profile_linking_hint
  • Updated message text to reference new key name in hint
+3/-3     
messages.json
Update Japanese locale for control profile linking             

locale/ja/messages.json

  • Renamed locale key mixer_pid_profile_linking to
    mixer_control_profile_linking
  • Renamed locale key mixer_pid_profile_linking_hint to
    mixer_control_profile_linking_hint
  • Updated Japanese message text to reference new key name
+3/-3     
messages.json
Update Ukrainian locale for control profile linking           

locale/uk/messages.json

  • Renamed locale key mixer_pid_profile_linking to
    mixer_control_profile_linking
  • Renamed locale key mixer_pid_profile_linking_hint to
    mixer_control_profile_linking_hint
  • Updated Ukrainian message text to reference new key name
+3/-3     
messages.json
Update Chinese locale for control profile linking               

locale/zh_CN/messages.json

  • Renamed locale key mixer_pid_profile_linking to
    mixer_control_profile_linking
  • Renamed locale key mixer_pid_profile_linking_hint to
    mixer_control_profile_linking_hint
  • Updated Chinese message text to reference new key name
+3/-3     

@MrD-RC MrD-RC added this to the 9.0 milestone Nov 19, 2025
@qodo-merge-pro
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No auditing: The PR only renames configuration and UI keys without adding or modifying any logging for
critical actions, which neither violates nor satisfies audit trail requirements based on
the visible diff.

Referred Code
'use_control_profile',
'throttle_scale',
'throttle_idle',
'turtle_mode_power_factor',
'failsafe_throttle',

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No error paths: The diff introduces a new checkbox binding without adding validation or error handling,
but UI markup alone may rely on existing handlers not shown here.

Referred Code
    <input id="mixer_control_profile_linking" type="checkbox" class="toggle" data-setting="mixer_control_profile_linking" />
    <label for="mixer_control_profile_linking"><span data-i18n="mixer_control_profile_linking"></span></label>
    <div class="helpicon cf_tip" data-i18n_title="mixer_control_profile_linking_hint"></div>
</div>

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Input validation: The new checkbox data-setting="mixer_control_profile_linking" introduces a new
external input path but the diff shows no validation or sanitization; this may be handled
elsewhere in JS not shown here.

Referred Code
<input id="mixer_control_profile_linking" type="checkbox" class="toggle" data-setting="mixer_control_profile_linking" />
<label for="mixer_control_profile_linking"><span data-i18n="mixer_control_profile_linking"></span></label>
<div class="helpicon cf_tip" data-i18n_title="mixer_control_profile_linking_hint"></div>

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@sensei-hacker sensei-hacker merged commit dd666d4 into master Nov 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants