-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New target: FlyingRC F4wing mini #11092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed configuration for permanent IDs and PWM mode in targetConfiguration function.
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||
|
You will need to update your branch from the current master for this build to compile. As this is a new board, it will need to comply with the New Hardware Policy to be added to the main branch. I also thing that this target should come with a warning. It is extremely cheap, so is made with low quality components. It is also lacking a lot of basic feature found on modern "wing" FCs. This should only be used on a park flyer, going no further than LOS distances. To be honest, I'm of two minds whether this target should be added at all. As I question the quality and reliability of the hardware. Which is a safety concern. |
✅
Not sure what you want me to do here.
I totally agree with the warning!
|
|
I really think this target should have been discussed before merging. The hardware seems unreliable. There are even comments about things not working in the threads on here. From a safety standpoint point. I think it should have been discussed before merging. |
|
Hear where you're coming from, Mr D. On the other hand, it doesn't seem like the most stable, reliable manufacturer. I probably wouldn't recommended this board other than maybe for sub 250 or smaller builds. What's the line between recommending and having it available? I wouldn't recommend a certain V3 board either. I wouldn't mind naming the target FLYRCF4WING_NOT_RECOMMENDED or something. :) |
|
IMHO, cheap should not be a consideration for the thing keeping your aircraft in the air. Especially when its saving $20 on an FC when people are willing to spend $120+ on a video system. FC, RX, and servos should be given cost priorities over the video link. Renaming the target seems like a good option. Also adding a document in the targets folder. It would be nice if these can be brought in to configurator on flashing at some point. |
|
I also noticed that SoftSerial has been added. But there is no physical connection for it on the FC. PA2 does not appear to be broken out. |
Do not worry to much about the stability of the FC. Most people who found that the fc did not work is because the fc comes in with AP firmware flashed. And when they try to flash matek f405 te inav into the fc, it will NOT boot correctly. This is because the fc does not have an osd chip, and INAV will not boot when an osd chip is added in firmware compilation but not detected in hardware. So, its really just software issues. |
User description
Added support for FlyingRC F4wing mini
see #11009 for more details
Test board has been shipped but, still on its way.
PR Type
Enhancement, New Target
Description
Add support for FlyingRC F4wing mini flight controller
Define timer hardware configuration for 6 servo outputs
Configure IMU, barometer, magnetometer, and rangefinder sensors
Set up UART and SoftSerial communication interfaces
Diagram Walkthrough
File Walkthrough
target.h
Board hardware and peripheral configurationsrc/main/target/FLYINGRCF4WINGMINI/target.h
sensors
ESC interface
target.c
Timer hardware definitions and servo mappingsrc/main/target/FLYINGRCF4WINGMINI/target.c
config.c
Target configuration function stubsrc/main/target/FLYINGRCF4WINGMINI/config.c
CMakeLists.txt
CMake build configuration for targetsrc/main/target/FLYINGRCF4WINGMINI/CMakeLists.txt