Add unit test to ensure onModelGeometryChanged() is called during rebase #8791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffank/rebase-geometric-changes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests to verify that the onModelGeometryChanged() event is properly fired during rebase operations with different types of local changes. The tests cover scenarios with no local changes, geometric changes, and non-geometric changes during pull/merge operations.
Key changes:
- Added new test cases for geometry change event tracking during rebase
- Enhanced test helpers to support geometry manipulation (insertRecipe2d, updateRecipe2d, geometry stream building)
- Updated existing tests to use proper prop1 values and renamed helper method for clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| core/backend/src/test/hubaccess/Rebase.test.ts | Added four new test cases for onModelGeometryChanged events, enhanced test helpers with geometry support, and updated test assertions |
| .github/copilot-instructions.md | New documentation file providing AI coding agent instructions for the iTwin.js project |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…iTwin/itwinjs-core into affank/rebase-geometric-changes
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
aruniverse
reviewed
Nov 20, 2025
aruniverse
reviewed
Nov 20, 2025
common/changes/@itwin/core-backend/affank-rebase-geometric-changes_2025-11-20-19-12.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.