cache bufnr to prevent error while processing autoclose autocmd#576
Open
ribru17 wants to merge 9 commits intoiamcco:masterfrom
Open
cache bufnr to prevent error while processing autoclose autocmd#576ribru17 wants to merge 9 commits intoiamcco:masterfrom
ribru17 wants to merge 9 commits intoiamcco:masterfrom
Conversation
Author
|
By the way I have tested this a good deal and I believe it closes #316. |
…ser default monospace
|
I'm hitting this as well... would love a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
I would frequently get errors while closing previewing markdown buffers saying:
This was because the auto-close autocmd would run after the buffer was already closed, and the plugin thought it needed to close my next opened buffer (some other non-markdown file) which of course was incorrect behavior.
Solution:
I fixed this by caching the buffer number of the actual markdown buffer I needed and then passing it down to each function that needed the buffer number to close it. I would really love to see this merged as this issue was quite annoying to me. Thanks for the great plugin