Add TwoPaneRight Layout #1685
Merged
Add TwoPaneRight Layout #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've opened an issue to request custom layout support for the native shrink/expand commands: |
rgeraskin
force-pushed
the
twopaneright
branch
from
ee1f2c2 to
b3c482b
Compare
|
rebased on 0.22.2 |
ianyh
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add it as a native layout because custom layouts do not support the native shrink/expand commands. I've successfully built this branch and use it daily.
I'm a total noob in swift, xcode and Amethyst codebase, plz review it attentively😎
Closes #1216
Related: #1347
It's a bit updated version of this PR #1515