Skip to content

Conversation

@maxicus
Copy link

@maxicus maxicus commented Jan 30, 2025

Add SNAP MID order type, quite simple one.

I noticed that other order-type classes were suggested, and I wanted to respond to this comment.

The primary goal of this library, as stated in the README, is "to make working with the Trader Workstation API from Interactive Brokers as easy as possible." If the library doesn’t support the various order types directly, people using it will be forced to write additional wrappers themselves to handle these order types, which could result in less readable code. This goes against the library's core intent. After all, ibapi already provides the raw interface to the IB API, and the real value of ib_async lies in simplifying that interface and making it more human-friendly.

To ensure these new classes are helpful, a few points should be addressed:

  • The constructor should define a minimum set of required arguments (similar to how existing order-type classes are structured).
  • Ideally, an example of how to use the new classes should be included to demonstrate their intended usage.

I’ve made both of these changes in the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants