IBX-10653: flatpickr doesn't save seconds (unless minutes or other elements are changed afterwards) #1747
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidarl
force-pushed
the
IBX-10653_flatpickr_doesnt_save_seconds_unless_minutes_or_other_elements_are_changed_afterwards
branch
from
4c2bd05 to
f27d459
Compare
dew326
approved these changes
Oct 20, 2025
albozek
approved these changes
Oct 21, 2025
GrabowskiM
requested changes
Oct 21, 2025
src/bundle/Resources/public/js/scripts/core/date.time.picker.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/core/date.time.picker.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/core/date.time.picker.js
Outdated
Show resolved
Hide resolved
vidarl
force-pushed
the
IBX-10653_flatpickr_doesnt_save_seconds_unless_minutes_or_other_elements_are_changed_afterwards
branch
from
7ab63d4 to
f818f66
Compare
|
vidarl
commented
Nov 6, 2025
| this.flatpickrInstance.hourElement.addEventListener('keyup', this.onKeyUp.bind(this, false), false); | ||
| this.flatpickrInstance.hourElement.addEventListener('keyup', this.onKeyUp.bind(this, 'hours'), false); | ||
| this.flatpickrInstance.minuteElement.addEventListener('keyup', this.onKeyUp.bind(this, 'minutes'), false); | ||
| if (this.flatpickrInstance.secondElement !== undefined) { |
Contributor
Author
There was a problem hiding this comment.
FYI : I also had to add this check as the existences of the secondElement is dependent on config: https://github.com/ibexa/admin-ui-assets/blob/v4.6.25/src/bundle/Resources/public/vendors/flatpickr/dist/esm/index.js#L722-L725
Contributor
Author
|
@GrabowskiM : Are you also okay with this PR now ? |
GrabowskiM
approved these changes
Jan 9, 2026
Contributor
yeah, really sorry for missing this message! Approved! :) |
pawlakadrian
force-pushed
the
IBX-10653_flatpickr_doesnt_save_seconds_unless_minutes_or_other_elements_are_changed_afterwards
branch
2 times, most recently
from
f818f66 to
5f59b47
Compare
pawlakadrian
approved these changes
Jan 28, 2026
Contributor
pawlakadrian
left a comment
pawlakadrian
left a comment
There was a problem hiding this comment.
QA Approved on DXP Commerce 4.6.x-dev
…ements are changed afterwards)
vidarl
force-pushed
the
IBX-10653_flatpickr_doesnt_save_seconds_unless_minutes_or_other_elements_are_changed_afterwards
branch
from
f8965a6 to
1682966
Compare
|
dew326
deleted the
IBX-10653_flatpickr_doesnt_save_seconds_unless_minutes_or_other_elements_are_changed_afterwards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Event listener for
secondelement missing, causing seconds not to be saved in the pickerFor QA:
Documentation: