IBX-10732: Fixed strict checking of ContentType IDs in ContentCreateContentTypeChoiceLoader #1804
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
requested changes
Jan 13, 2026
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
I don't think we should remove strict type checking. What I suggest instead is casting content type ids to integers and then perform in_array with true flag as before.
…ontentTypeChoiceLoader
…CreateContentTypeChoiceLoader
vidarl
force-pushed
the
IBX-10732_Fixed_strict_checking_of_ContentType_IDs_in_ContentCreateContentTypeChoiceLoader
branch
from
bf9ac00 to
dfa5a8b
Compare
|
Contributor
Author
Fixed in dfa5a8b |
konradoboza
approved these changes
Jan 27, 2026
barw4
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A regression was made in b9575cf, b9575cf#diff-bbe0728a3f61fb1fc42bc831831ee9e83329a64d9c0fea169871ecd1ad4cf6b1R77 ( Unfortunately, the page doesn't scroll down to line 77 in ContentCreateContentTypeChoiceLoader.php automatically )
$contentType->idwill be an int ( ie2), while$this->restrictedContentTypesIdscomming from the permission resolver will be an array of strings ( ie `["1", "2"] )For QA:
See ticket description on how to reproduce
Documentation: