IBX-10186: Added limits to repository child count queries and subtree operations #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiewiurdp
force-pushed
the
IBX-10186-added-limits-to-repository-count
branch
5 times, most recently
from
0926a1a to
6596463
Compare
wiewiurdp
force-pushed
the
IBX-10186-added-limits-to-repository-count
branch
15 times, most recently
from
28628a2 to
4e34452
Compare
ibexa-workflow-automation-1
bot
requested review from
alongosz
and removed request for
a team
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
barw4,
ciastektk,
konradoboza,
mikadamczyk and
tbialcz
wiewiurdp
changed the title
konradoboza
reviewed
Jan 19, 2026
| $currentScope, | ||
| $scopeSettings['subtree_operations']['copy_subtree']['limit'] | ||
| ); | ||
| if (isset($scopeSettings['subtree_operations']['copy_subtree']['limit'])) { |
Contributor
There was a problem hiding this comment.
Those changes should be reflected in Ibexa\Tests\Bundle\AdminUi\DependencyInjection\Configuration\Parser\SubtreeOperationsTest.
Steveb-p
approved these changes
Jan 22, 2026
| ->children() | ||
| ->integerNode('limit') | ||
| ->info('Limit the total count of items queried for when calculating the the number of direct children a node has. -1 for no limit.') | ||
| ->isRequired() |
Contributor
There was a problem hiding this comment.
We cannot "require" this node, as we have defaults declared outside of configuration processing.
With this require, if query_subtree element is added, limit has to be declared regardless if you want to change the limit in a specific site-access or not.
Suggested change
| ->isRequired() |
mikadamczyk
approved these changes
Jan 22, 2026
wiewiurdp
force-pushed
the
IBX-10186-added-limits-to-repository-count
branch
from
3f39e75 to
ef7cd51
Compare
konradoboza
approved these changes
Jan 28, 2026
| ->arrayNode('query_subtree') | ||
| ->children() | ||
| ->integerNode('limit') | ||
| ->info('Limit the total count of items queried for when calculating the the number of direct children a node has. -1 for no limit.') |
Contributor
There was a problem hiding this comment.
Suggested change
| ->info('Limit the total count of items queried for when calculating the the number of direct children a node has. -1 for no limit.') | |
| ->info('Limit the total count of items queried for when calculating the number of direct children a node has. -1 for no limit.') |
wiewiurdp
force-pushed
the
IBX-10186-added-limits-to-repository-count
branch
from
b050e3f to
ec11937
Compare
wiewiurdp
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
#1605
ibexa/core#696
Description:
This one is a community contribution from @ryanolee 🎉 .
This pull request introduces performance optimizations for repository operations by implementing limits on child count queries and subtree operations.
More info here:
#1605
For QA:
See orginal PR
Documentation:
New configuration of limits added