Skip to content

IBX-11370: Added parameter offset for tooltips #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OstafinL wants to merge 2 commits into
base: main
Choose a base branch
from
Open

IBX-11370: Added parameter offset for tooltips #1845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59b9aef
IBX-11370: Added parameter offset for tooltips
OstafinL Mar 9, 2026
8b477d6
Refactored RoleAssignmentCreateDataValidationTest to remove redundant…
Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/bundle/Resources/public/js/scripts/helpers/tooltips.helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ const initializeTooltip = (tooltipNode, hasEllipsisStyle) => {
const placement = tooltipNode.dataset.tooltipPlacement ?? defaultPlacement;
const trigger = tooltipNode.dataset.tooltipTrigger ?? defaultTrigger;
const useHtml = tooltipNode.dataset.tooltipUseHtml !== undefined;
const offset = tooltipNode.dataset.tooltipOffset ? JSON.parse(tooltipNode.dataset.tooltipOffset) : undefined;
const container = getContainer(tooltipNode);
const iframe = document.querySelector(tooltipNode.dataset.tooltipIframeSelector);

Expand All @@ -172,6 +173,7 @@ const initializeTooltip = (tooltipNode, hasEllipsisStyle) => {
popperConfig: modifyPopperConfig.bind(null, iframe),
html: useHtml,
template: defaultTemplate(extraClass),
...(offset && { offset }),
});

if (isSafari()) {
Expand Down
5 changes: 0 additions & 5 deletions tests/lib/Form/Data/Role/RoleAssignmentCreateDataValidationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ public static function getDataForTestFormSubmitValidation(): iterable
['{{ value }}' => 'foo'],
'children[limitation_type]'
),
new FormErrorDataTestWrapper(
'The selected choice is invalid.',
['{{ value }}' => 'foo'],
'children[limitation_type]'
),
],
];

Expand Down
Loading