Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(decimal): add xfailing test constructing memtable decimal columns with integers #10486

Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Nov 13, 2024

During work on another PR, I found that memtables with decimal columns, whose data originate from integers cannot be executed. It turns out this might be a bug upstream (apache/arrow#44712), so here I am just adding a test that will start to fail if this is ever fixed in pyarrow.

@cpcloud cpcloud added this to the 10.0 milestone Nov 13, 2024
@cpcloud cpcloud added tests Issues or PRs related to tests datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Nov 13, 2024
@cpcloud cpcloud force-pushed the test-decimal-memtable-construction branch from 7b4c5b8 to b272bae Compare November 13, 2024 17:37
@cpcloud cpcloud force-pushed the test-decimal-memtable-construction branch from b272bae to 39d68a2 Compare November 13, 2024 18:18
@cpcloud cpcloud merged commit 7ac1487 into ibis-project:main Nov 14, 2024
75 checks passed
@cpcloud cpcloud deleted the test-decimal-memtable-construction branch November 14, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant