feat(ci): self-signed Windows build pipeline (x64 + arm64) - #162
Open
sonegillis1 wants to merge 1 commit into
Open
feat(ci): self-signed Windows build pipeline (x64 + arm64)#162sonegillis1 wants to merge 1 commit into
sonegillis1 wants to merge 1 commit into
Conversation
Mirrors the macOS DMG pipeline for Windows, in its own pipeline off the same app-v* tag (as done for the OS/mentorai app): - reusable-release-windows.yml: matrix build of self-signed NSIS installers for x86_64 + aarch64 (arm64 cross-compiled on windows-latest). Signs with a stored self-signed .pfx (WINDOWS_CERTIFICATE/WINDOWS_CERTIFICATE_PASSWORD secrets) when present, else generates one in the runner. Injects the thumbprint into tauri.conf.json in place (preserving sibling windows settings), verifies the installer is signed, uploads per-arch artifacts, and attaches installers to the app-v<X> Release (race-safe for the concurrent matrix). - release-windows.yml: caller triggered by app-v* tags + workflow_dispatch. - tauri.conf.json: add the windows bundle block (certificateThumbprint, sha256, timestamp, NSIS currentUser, WebView2 downloadBootstrapper). - tauri-bump.mjs: also record Windows x64/arm64 installer links (asset names use space->dot like the DMG) in docs/DOWNLOADS.md + a "Latest Windows build" line. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
Claude finished @sonegillis1's task —— View job E2E Coverage Review
✅ E2E Coverage — No IssuesChanged files:
No new
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replicates the OS/mentorai Windows build pipeline for Agentic LMS — self-signed NSIS installers for Intel x64 and ARM64, in their own pipeline off the same
app-v*tag the mac build uses. Mirrors this repo's existing macOS DMG pipeline exactly.reusable-release-windows.yml— matrix{x64: x86_64-pc-windows-msvc, arm64: aarch64-pc-windows-msvc}onwindows-latest(arm64 cross-compiled). Builds--bundles nsis, uploads a per-arch artifact, attaches*-setup.exeto theapp-v<X>Release (race-safe for the concurrent legs).WINDOWS_CERTIFICATE/WINDOWS_CERTIFICATE_PASSWORDsecrets if present. Thumbprint is injected in place intotauri.conf.json(preserving siblingwindowssettings), and a post-build step verifies the installer is signed.release-windows.yml— tag-triggered caller (+workflow_dispatchfor build-only artifacts), "Agentic LMS" naming.tauri.conf.json— adds thewindowsbundle block (certificateThumbprint, sha256, timestamp, NSIScurrentUser, WebView2downloadBootstrapper).tauri-bump.mjs— records Windows x64/arm64 installer links inDOWNLOADS.md+ a "Latest Windows build" README line. Asset names use the samespace→dottreatment as the DMG (Agentic.LMS_…). Verified with a drypatchrun, then reverted.This is the same hardened workflow shipped for OS/mentorai (research-backed: in-place thumbprint injection, signing verification, arm64 tools pre-installed on GitHub runners, NSIS-only bundles since WiX has no arm64).
New, untested-in-CI pipeline. First
app-v*tag (or aworkflow_dispatchbuild-only run) should confirm the arm64 cross-compile, the exact NSIS filenames (esp. theAgentic LMS→Agentic.LMSspace handling on the uploaded asset), and signing. Recommend a build-only dispatch first.