Skip to content

WIP: Request body serializer #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1120
Choose a base branch
from

Conversation

abhilashraju
Copy link
Contributor

bmcweb changes for serialising request body into file
Signed-off-by: Abhilash Raju [email protected]

bmcweb changes for serialising request body into file
Signed-off-by: Abhilash Raju <[email protected]>
@baemyung
Copy link
Contributor

This seems putting the request body into a file - which seems good for the given purpose.
However, I'm wondering how body() function will be handled as it becomes empty for this route.

bmcweb uses body() in many places.
How can we make sure not to use it in this path?

Perhaps, can this feature be enabled by an meson option, and/or by a dynamic option (as a part of Request header)?
Also, going through upstream community first?

@abhilashraju
Copy link
Contributor Author

This seems putting the request body into a file - which seems good for the given purpose. However, I'm wondering how body() function will be handled as it becomes empty for this route.

bmcweb uses body() in many places. How can we make sure not to use it in this path?

Perhaps, can this feature be enabled by an meson option, and/or by a dynamic option (as a part of Request header)? Also, going through upstream community first?

Serialization is not applied by default. You can refer to the update service route registration handler to see how serialization is enabled for a specific URL. In these cases, the handler chooses to stream the request body directly into a file, so it does not use the body() call on the request object. By default, all other handlers read the body into a string as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants